Fix deprecated golangci-lint config #2718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Executing `golangci-lint run` using old config generates the following warnings: WARN [config_reader] The configuration option `run.skip-dirs-use-default` is deprecated, please use `issues.exclude-dirs-use-default`. WARN [config_reader] The configuration option `linters.govet.check-shadowing` is deprecated. Please enable `shadow` instead, if you are not using `enable-all`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2718 +/- ##
==========================================
- Coverage 76.41% 76.31% -0.11%
==========================================
Files 87 87
Lines 9967 9967
==========================================
- Hits 7616 7606 -10
- Misses 1879 1886 +7
- Partials 472 475 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thank you so much @mogren excited to get your help. Can you make this against https://github.com/pion/.goassets/blob/master/ci/.golangci.yml when you push a tag to that repo it syncs across everything then. |
|
Thanks! Just testing so that I have things set up right 😄 |
|
Moved to pion/.goassets#208 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executing
golangci-lint runusing old config generates the following warnings:WARN [config_reader] The configuration option
run.skip-dirs-use-defaultis deprecated, please useissues.exclude-dirs-use-default.WARN [config_reader] The configuration option
linters.govet.check-shadowingis deprecated. Please enableshadowinstead, if you are not usingenable-all.Description
Before change:
After change:
Reference issue
No issue filed for this warning.